[webkit-reviews] review granted: [Bug 200669] Remove SessionID default constructor : [Attachment 376159] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 13 10:56:13 PDT 2019


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 200669: Remove SessionID default constructor
https://bugs.webkit.org/show_bug.cgi?id=200669

Attachment 376159: Patch

https://bugs.webkit.org/attachment.cgi?id=376159&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376159
  --> https://bugs.webkit.org/attachment.cgi?id=376159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376159&action=review

> Source/WebCore/PAL/pal/SessionID.h:-35
> -    SessionID()

Maybe explicitly have = delete.

> Source/WebCore/platform/network/CookieRequestHeaderFieldProxy.h:67
> +	   return { };

nullopt

> Source/WebKit/Shared/WebPageCreationParameters.h:100
> +    PAL::SessionID sessionID { PAL::SessionID::emptySessionID() };

I don't think this should be necessary.  Just go to the places where one of
these is created and put the value in the constructor.

> Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:52
> +    : m_sessionID(PAL::SessionID::emptySessionID())

ditto.


More information about the webkit-reviews mailing list