[webkit-reviews] review granted: [Bug 200663] Fail decoding an invalid SessionID : [Attachment 376152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 13 10:47:42 PDT 2019

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 200663: Fail decoding an invalid SessionID

Attachment 376152: Patch


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376152
  --> https://bugs.webkit.org/attachment.cgi?id=376152

View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review

> Source/WebCore/PAL/pal/SessionID.h:86
> +    // FIXME: Change to a regular ASSERT.
> +    RELEASE_ASSERT(isValid());

I think we should just leave it a RELEASE_ASSERT

More information about the webkit-reviews mailing list