[webkit-reviews] review granted: [Bug 200673] Incorrect head in fast/canvas/webgl/gl-get-calls.html causes test failure : [Attachment 376169] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 13 09:09:07 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 200673: Incorrect head in fast/canvas/webgl/gl-get-calls.html causes test

Attachment 376169: Patch


--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 376169
  --> https://bugs.webkit.org/attachment.cgi?id=376169

View in context: https://bugs.webkit.org/attachment.cgi?id=376169&action=review

I would call this a real bug in these ports, as content sniffing local files is
no less dangerous than content sniffing resources served by HTTP. This file
just shouldn't be parsed as XML. Also, there is an explicit meta http-equiv
that should be respected when content sniffing.

But it's OK to correct the test.

> LayoutTests/fast/canvas/webgl/gl-get-calls.html:1

HTML5 doctype is "<!DOCTYPE html>" (lower case).

More information about the webkit-reviews mailing list