[webkit-reviews] review granted: [Bug 200606] [WebGPU] Improve GPUBindGroup performance using one device-shared argument MTLBuffer : [Attachment 376106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 19:21:59 PDT 2019


Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 200606: [WebGPU] Improve GPUBindGroup performance using one device-shared
argument MTLBuffer
https://bugs.webkit.org/show_bug.cgi?id=200606

Attachment 376106: Patch

https://bugs.webkit.org/attachment.cgi?id=376106&action=review




--- Comment #8 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 376106
  --> https://bugs.webkit.org/attachment.cgi?id=376106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376106&action=review

r=me assuming there are links to follow-up bugs about compaction and shrinking.

> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:83
> +	   // Based off mimimum allocation for a memory-shared MTLBuffer on
macOS.

don't you mean "shared memory"

> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:127
> +

Seems like this could benefit from a FIXME with a link to a bug about
compaction


More information about the webkit-reviews mailing list