[webkit-reviews] review denied: [Bug 200553] shouldRespectImageOrientation should be a value in ImageOrientation : [Attachment 376089] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 200553: shouldRespectImageOrientation should be a value in ImageOrientation
https://bugs.webkit.org/show_bug.cgi?id=200553

Attachment 376089: Patch

https://bugs.webkit.org/attachment.cgi?id=376089&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 376089
  --> https://bugs.webkit.org/attachment.cgi?id=376089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376089&action=review

We're going to force call sites to be explicit about whether they want
from-image.

> Source/WebCore/platform/graphics/ImageOrientation.h:56
> +	   Default	     = None,
> +
> +	   EXIFFirst	     = OriginTopLeft,
> +	   EXIFLast	     = OriginLeftBottom,
> +
> +	   First	     = FromImage,
> +	   Last 	     = EXIFLast

Maybe moved these out and just define them where they get used.

> Source/WebCore/platform/graphics/ImageOrientation.h:71
> +    operator int() const { return static_cast<int>(m_orientation); }

Remove this.

> Source/WebCore/platform/graphics/ImageOrientation.h:-79
> -    ImageOrientationEnum imageOrientation() { return m_orientation; }

Keep this, call it .value()? Callers should switch on this.