[webkit-reviews] review granted: [Bug 200583] User Agent and SessionID should be given to NetworkRTCProvider to set up the correct proxy information : [Attachment 376072] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 200583: User Agent and SessionID should be given to NetworkRTCProvider to
set up the correct proxy information
https://bugs.webkit.org/show_bug.cgi?id=200583

Attachment 376072: Patch

https://bugs.webkit.org/attachment.cgi?id=376072&action=review




--- Comment #14 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 376072
  --> https://bugs.webkit.org/attachment.cgi?id=376072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376072&action=review

> Source/WebCore/ChangeLog:8
> +	   Use a specific socket factory that is specific to the user agent and
session ID.

Nit: s/a specific socket factory/a socket factory/

> Source/WebKit/ChangeLog:9
> +	   Use of this information to get the proxy information from
NetworkSession and pass it to libwebrtc socket creation.

Nit: s/Use of this/Use this/

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:31
> +OBJC_CLASS NSURLSessionConfiguration;

Nit: it doesn't look like this is needed (yet)