[webkit-reviews] review granted: [Bug 200628] Crash under NetworkResourceLoader::start() : [Attachment 376064] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 12 09:24:35 PDT 2019
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200628: Crash under NetworkResourceLoader::start()
https://bugs.webkit.org/show_bug.cgi?id=200628
Attachment 376064: Patch
https://bugs.webkit.org/attachment.cgi?id=376064&action=review
--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 376064
--> https://bugs.webkit.org/attachment.cgi?id=376064
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376064&action=review
> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:219
> + auto protectedThis = makeRef(*this);
We might not need that ref here anymore.
The code below is new and handles prefetch, I doubt it can trigger a loader
cancellation.
More information about the webkit-reviews
mailing list