[webkit-reviews] review granted: [Bug 200598] Web Inspector: Address some ESLint warnings : [Attachment 375977] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 16:36:02 PDT 2019


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200598: Web Inspector: Address some ESLint warnings
https://bugs.webkit.org/show_bug.cgi?id=200598

Attachment 375977: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=375977&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 375977
  --> https://bugs.webkit.org/attachment.cgi?id=375977
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=375977&action=review

r=me, awesome

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:734
> +	   // FIXME: Return values from this are crazy.

I think this function can be removed entirely.	Nobody seems to call it :P


More information about the webkit-reviews mailing list