[webkit-reviews] review granted: [Bug 200589] Fix Crash in Mail Search : [Attachment 375968] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 15:50:49 PDT 2019

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 200589: Fix Crash in Mail Search

Attachment 375968: Patch


--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 375968
  --> https://bugs.webkit.org/attachment.cgi?id=375968

View in context: https://bugs.webkit.org/attachment.cgi?id=375968&action=review

> Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:84
> -	       allMatches[matchIndex].appendVector(matchRects);
> +	       if (matchIndex >= 0 && (uint32_t)matchIndex < matchCount)

This is fine for now given current clients, but maybe leave a FIXME that we
should have match rects when doing an incremental backwards search (did you
test Notes??).

More information about the webkit-reviews mailing list