[webkit-reviews] review granted: [Bug 200594] Web Inspector: Better organize manager / observer API groups : [Attachment 375970] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200594: Web Inspector: Better organize manager / observer API groups
https://bugs.webkit.org/show_bug.cgi?id=200594

Attachment 375970: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=375970&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 375970
  --> https://bugs.webkit.org/attachment.cgi?id=375970
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=375970&action=review

r=me, 1000% YES

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:570
> -    reset()
> +    globalObjectCleared()

I've never been happier with a change in all my life ��

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:382
> +    // ConsoleObserver

What about `// ScriptProfilerObserver`?