[webkit-reviews] review granted: [Bug 200591] [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error : [Attachment 375961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 14:53:03 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 200591: [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and
sometimes produces an error
https://bugs.webkit.org/show_bug.cgi?id=200591

Attachment 375961: Patch

https://bugs.webkit.org/attachment.cgi?id=375961&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 375961
  --> https://bugs.webkit.org/attachment.cgi?id=375961
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826
> +    switch (_focusedElementInformation.elementType) {
> +    case WebKit::InputType::Password:

Either plain text field doesn't support pasting of an image,
or all these could potentially support pasting of an image if we rely on page's
scripts.

r=me with this element type check removed as we discussed in person.


More information about the webkit-reviews mailing list