[webkit-reviews] review granted: [Bug 200588] [iOS WK2] Remove context menu previews on navigation : [Attachment 375950] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 200588: [iOS WK2] Remove context menu previews on navigation
https://bugs.webkit.org/show_bug.cgi?id=200588

Attachment 375950: Patch

https://bugs.webkit.org/attachment.cgi?id=375950&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 375950
  --> https://bugs.webkit.org/attachment.cgi?id=375950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375950&action=review

> Source/WebKit/ChangeLog:9
> +	   Make sure the context menu preview doesn't linger across navigations
by hosting it in its

hint! the preview is the platter that is presented above the context menu.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3954
> +    [self _hideContextMenu];

You don't hide the menu, just the hint

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6397
> +    if (_contextMenuContainerView) {

Ditto