[webkit-reviews] review granted: [Bug 200579] Tapping buttons in Data Detectors lookup previews doesn't work : [Attachment 375933] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 200579: Tapping buttons in Data Detectors lookup previews doesn't work
https://bugs.webkit.org/show_bug.cgi?id=200579

Attachment 375933: Patch

https://bugs.webkit.org/attachment.cgi?id=375933&action=review




--- Comment #4 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 375933
  --> https://bugs.webkit.org/attachment.cgi?id=375933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375933&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8298
> +    if ([configuration isKindOfClass:getDDContextMenuConfigurationClass()])
{

File a bug to clean this all up once the SPI has settled?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8305
> +	   shouldExpandPreview =
!!ddConfiguration.interactionViewControllerProvider;

I find it odd that the SPI had a var for this, but now does not? But I'm
assuming you know what's going on here..