[webkit-reviews] review granted: [Bug 200525] [WHLSL] Trivial clean-up of the MSL code generated : [Attachment 375771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 09:59:43 PDT 2019

Darin Adler <darin at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 200525: [WHLSL] Trivial clean-up of the MSL code generated

Attachment 375771: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 375771
  --> https://bugs.webkit.org/attachment.cgi?id=375771

View in context: https://bugs.webkit.org/attachment.cgi?id=375771&action=review

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:253
> +	   m_stringBuilder.append("\n");

I think that appending a single character is slightly more efficient if you use
the character: append('\n')

More information about the webkit-reviews mailing list