[webkit-reviews] review granted: [Bug 200571] Pass a ScriptExecutionContext as input to register/unregister URLRegistry routines : [Attachment 375907] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 200571: Pass a ScriptExecutionContext as input to register/unregister
URLRegistry routines
https://bugs.webkit.org/show_bug.cgi?id=200571

Attachment 375907: Patch

https://bugs.webkit.org/attachment.cgi?id=375907&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 375907
  --> https://bugs.webkit.org/attachment.cgi?id=375907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375907&action=review

> Source/WebCore/html/PublicURLManager.cpp:54
> +    found->key->registerURL(*scriptExecutionContext(), url, registrable);

What guarantees it’s non-null?

> Source/WebCore/html/PublicURLManager.cpp:62
> +	       registry.key->unregisterURL(*scriptExecutionContext(), url);

What guarantees it’s non-null?

> Source/WebCore/html/PublicURLManager.cpp:77
> +	       registry.key->unregisterURL(*scriptExecutionContext(), URL({ },
url));

What guarantees it’s non-null?