[webkit-reviews] review denied: [Bug 17240] Web Inspector: implement blackboxing of script resources : [Attachment 375517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 13:21:37 PDT 2019

Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 17240: Web Inspector: implement blackboxing of script resources

Attachment 375517: Patch


--- Comment #38 from Brian Burg <bburg at apple.com> ---
Comment on attachment 375517
  --> https://bugs.webkit.org/attachment.cgi?id=375517

View in context: https://bugs.webkit.org/attachment.cgi?id=375517&action=review

You forgot to include SourceCodeTreeElement.css in your patch, so I can't test
it out (rendering is really off).

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:184
> +	   // FIXME: Handle other backend pause reasons.

Like what?

More information about the webkit-reviews mailing list