[webkit-reviews] review granted: [Bug 200543] [Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions : [Attachment 375829] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 12:24:47 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 200543: [Mac] Use the PID of the WebContent process when issuing local file
read sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=200543

Attachment 375829: Patch

https://bugs.webkit.org/attachment.cgi?id=375829&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 375829
  --> https://bugs.webkit.org/attachment.cgi?id=375829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375829&action=review

Looks good.

> Source/WebKit/ChangeLog:9
> +	   the WebContent process.

Maybe it would be better phrased as:

"Adopt SPI to issue a process-specific sandbox extension for local file read,
passing it the process identifier of the WebContent process."


More information about the webkit-reviews mailing list