[webkit-reviews] review granted: [Bug 200541] OpenSource MemoryFootprint API for JSC command line tool : [Attachment 375821] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 200541: OpenSource MemoryFootprint API for JSC command line tool
https://bugs.webkit.org/show_bug.cgi?id=200541

Attachment 375821: Patch

https://bugs.webkit.org/attachment.cgi?id=375821&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375821
  --> https://bugs.webkit.org/attachment.cgi?id=375821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375821&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:144
> +    MemoryFootprint(const ProcessMemoryFootprint& o)
> +	   : ProcessMemoryFootprint(o)

style nit: let's give it a name instead of "o"

> Source/WTF/wtf/spi/darwin/ProcessMemoryFootprint.h:46
> +#if !PLATFORM(IOS_FAMILY_SIMULATOR) && __has_include(<libproc.h>)
> +#	include <libproc.h>
> +#	if RUSAGE_INFO_CURRENT >= 4
> +#	    define HAS_MAX_FOOTPRINT
> +#	    if defined(RLIMIT_FOOTPRINT_INTERVAL) &&
__has_include(<libproc_internal.h>) \
> +		&& ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED
>= 120000) \
> +		    || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >=
101400))
> +#		define HAS_RESET_FOOTPRINT_INTERVAL
> +#		define MAX_FOOTPRINT_FIELD ri_interval_max_phys_footprint
> +#		include <libproc_internal.h>
> +#	    else
> +#		define MAX_FOOTPRINT_FIELD ri_lifetime_max_phys_footprint
> +#	    endif
> +#	else
> +#	    define HAS_ONLY_PHYS_FOOTPRINT
> +#	endif
> +#endif

I respect the indentation here