[webkit-reviews] review granted: [Bug 200527] Move classes declared inside StorageManager.cpp into their own headers : [Attachment 375777] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 08:57:49 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 200527: Move classes declared inside StorageManager.cpp into their own

Attachment 375777: Patch


--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375777
  --> https://bugs.webkit.org/attachment.cgi?id=375777

View in context: https://bugs.webkit.org/attachment.cgi?id=375777&action=review

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:37
> +// FIXME: The quota value is copied from GroupSettings.cpp.

I'm not sure this comment is current.  This file doesn't exist any more.

> Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp:40
> +    : m_localStorageNamespace(localStorageNamespace ?
makeWeakPtr(*localStorageNamespace) : nullptr)

Can't we just use the makeWeakPtr overload that takes a pointer now?

> Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.h:55
> +    const unsigned m_quotaInBytes;

There are many of these that don't have default initializers in the headers. 
It might be worth adding some.

More information about the webkit-reviews mailing list