[webkit-reviews] review granted: [Bug 200530] [GTK] WebKitWebProcess crashes when viewing an HTML with a <video> element referencing unknown file : [Attachment 375793] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 200530: [GTK] WebKitWebProcess crashes when viewing an HTML with a <video>
element referencing unknown file
https://bugs.webkit.org/show_bug.cgi?id=200530

Attachment 375793: Patch

https://bugs.webkit.org/attachment.cgi?id=375793&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 375793
  --> https://bugs.webkit.org/attachment.cgi?id=375793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375793&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1659
> +    if (m_errorOccured) {
> +	   GST_DEBUG_OBJECT(pipeline(), "[Buffering] An error occurred,
disabling the fill timer");
> +	   m_fillTimer.stop();
> +	   return;
> +    }
> +

You can move this piece of code to the beginning of the method. We don't need
to initialize anything if we're going to bail out.