[webkit-reviews] review granted: [Bug 200531] REGRESSION (iOS 13): united.com web forms do not respond to taps : [Attachment 375786] Fixes the bug

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 200531: REGRESSION (iOS 13): united.com web forms do not respond to taps
https://bugs.webkit.org/show_bug.cgi?id=200531

Attachment 375786: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=375786&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 375786
  --> https://bugs.webkit.org/attachment.cgi?id=375786
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=375786&action=review

> Source/WebCore/page/Quirks.cpp:417
> +    DOMTokenList& classList = parentElement->classList();
> +    if (!classList.contains("feedback") ||
!classList.contains("feedback-mid"))
> +	   return false;
> +
> +    if
(!equalLettersIgnoringASCIICase(topPrivatelyControlledDomain(m_document->url().
host().toString()), "united.com"))
> +	   return false;

It is bit weird to test for class names before the host. It would be better to
write this so that adding another case doesn't require reorganizing the code.