[webkit-reviews] review granted: [Bug 200481] Web Inspector: RTL: content of Variables section should always be LTR : [Attachment 375657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 7 13:51:28 PDT 2019


Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 200481: Web Inspector: RTL: content of Variables section should always be
LTR
https://bugs.webkit.org/show_bug.cgi?id=200481

Attachment 375657: Patch

https://bugs.webkit.org/attachment.cgi?id=375657&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 375657
  --> https://bugs.webkit.org/attachment.cgi?id=375657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375657&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:124
> +	   variablesRow.element.dir = "ltr";

Can we put this on `this._variablesTextEditor.element` instead?  That way, its
more "contained" to only what needs to be LTR.


More information about the webkit-reviews mailing list