[webkit-reviews] review granted: [Bug 200451] Tighten WeakPtr threading assertions for GC threads : [Attachment 375726] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 7 13:02:35 PDT 2019
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200451: Tighten WeakPtr threading assertions for GC threads
https://bugs.webkit.org/show_bug.cgi?id=200451
Attachment 375726: Patch
https://bugs.webkit.org/attachment.cgi?id=375726&action=review
--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 375726
--> https://bugs.webkit.org/attachment.cgi?id=375726
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375726&action=review
> Source/WTF/wtf/WeakPtr.h:102
> + // FIXME: Our GC threads currently need to get opaque pointers from
WeakPtrs and have to be special-cased.
Do we have a plan to further tighten things?
It seems fine to get access to a value stored in a DOM object from GC thread,
be it an integer, a raw pointer or a weak pointer.
More information about the webkit-reviews
mailing list