[webkit-reviews] review granted: [Bug 200508] RegisterSet should be constexpr : [Attachment 375716] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 7 11:19:23 PDT 2019
Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 200508: RegisterSet should be constexpr
https://bugs.webkit.org/show_bug.cgi?id=200508
Attachment 375716: Patch
https://bugs.webkit.org/attachment.cgi?id=375716&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375716
--> https://bugs.webkit.org/attachment.cgi?id=375716
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review
very nice
> Source/JavaScriptCore/jit/RegisterSet.h:251
> +namespace JSC {
style nit: newline after this
> Source/JavaScriptCore/jit/RegisterSet.h:545
> +}
nit: // namespace JSC
More information about the webkit-reviews
mailing list