[webkit-reviews] review denied: [Bug 200487] [iOS] Position image information should respect the image orientation : [Attachment 375663] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 7 10:06:38 PDT 2019
Tim Horton <thorton at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 200487: [iOS] Position image information should respect the image
orientation
https://bugs.webkit.org/show_bug.cgi?id=200487
Attachment 375663: Patch
https://bugs.webkit.org/attachment.cgi?id=375663&action=review
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 375663
--> https://bugs.webkit.org/attachment.cgi?id=375663
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375663&action=review
>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2638
>> + graphicsContext->drawImage(*image, FloatRect(0, 0, bitmapSize.width(),
bitmapSize.height()), ImageOrientationDescription(RespectImageOrientation));
>
> Isn't bitmapSize above also going to need a fix?
You explained that it doesn't. but you also need to follow the current state of
the RenderImage's respect, not just respect willy-nilly.
More information about the webkit-reviews
mailing list