[webkit-reviews] review granted: [Bug 200490] Extra space inserted at start of line when inserting a newline in Mail compose : [Attachment 375673] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 7 07:55:00 PDT 2019
Antti Koivisto <koivisto at iki.fi> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 200490: Extra space inserted at start of line when inserting a newline in
Mail compose
https://bugs.webkit.org/show_bug.cgi?id=200490
Attachment 375673: Patch
https://bugs.webkit.org/attachment.cgi?id=375673&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 375673
--> https://bugs.webkit.org/attachment.cgi?id=375673
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review
> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53
> +bool containsOffset(const RenderObject&, const Layout&, unsigned);
This declaration has different signature than the definition below (no
OffsetType).
> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122
> + bool isCaretOffsetType = offsetType == OffsetType::CaretOffset;
This helper bool doesn't seem necessary.
More information about the webkit-reviews
mailing list