[webkit-reviews] review granted: [Bug 200462] [WHLSL] cache results of argumentTypeForAndOverload inside Checker : [Attachment 375683] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 6 21:34:19 PDT 2019

Saam Barati <sbarati at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 200462: [WHLSL] cache results of argumentTypeForAndOverload inside Checker

Attachment 375683: patch


--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375683
  --> https://bugs.webkit.org/attachment.cgi?id=375683

View in context: https://bugs.webkit.org/attachment.cgi?id=375683&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:-106
> -	   static const bool emptyValueIsZero = true;

This was bogus, which is why I'm removing it. (This should belong on Traits.
And we never use these Traits as values in a hash table.)

More information about the webkit-reviews mailing list