[webkit-reviews] review granted: [Bug 200462] [WHLSL] cache results of argumentTypeForAndOverload inside Checker : [Attachment 375683] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 200462: [WHLSL] cache results of argumentTypeForAndOverload inside Checker
https://bugs.webkit.org/show_bug.cgi?id=200462

Attachment 375683: patch

https://bugs.webkit.org/attachment.cgi?id=375683&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375683
  --> https://bugs.webkit.org/attachment.cgi?id=375683
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375683&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:-106
> -	   static const bool emptyValueIsZero = true;

This was bogus, which is why I'm removing it. (This should belong on Traits.
And we never use these Traits as values in a hash table.)