[webkit-reviews] review granted: [Bug 200216] [iPadOS] slides.google.com: tapping near cursor in a slide title focuses the speaker notes : [Attachment 375674] EWS build fix

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 200216: [iPadOS] slides.google.com: tapping near cursor in a slide title
focuses the speaker notes
https://bugs.webkit.org/show_bug.cgi?id=200216

Attachment 375674: EWS build fix

https://bugs.webkit.org/attachment.cgi?id=375674&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 375674
  --> https://bugs.webkit.org/attachment.cgi?id=375674
EWS build fix

View in context: https://bugs.webkit.org/attachment.cgi?id=375674&action=review

> Source/WebKit/ChangeLog:16
> +	   touchend / pointerup evnets are dispatched but this is rather risky
since that could affact random

Nit - evnets => events, affact => affect

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:944
> +    if (m_pendingInputModeChange)
> +	  
pageClient().focusedElementDidChangeInputMode(*m_pendingInputModeChange);

Would it make sense to clear out m_pendingInputModeChange after we use it here?