[webkit-reviews] review granted: [Bug 195012] Make JSC memory benchmark available on OpenSource : [Attachment 375647] Updated patch responding to review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 6 15:10:36 PDT 2019


Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 195012: Make JSC memory benchmark available on OpenSource
https://bugs.webkit.org/show_bug.cgi?id=195012

Attachment 375647: Updated patch responding to review comments

https://bugs.webkit.org/attachment.cgi?id=375647&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375647
  --> https://bugs.webkit.org/attachment.cgi?id=375647
Updated patch responding to review comments

r=me

Can we also make it so we stub out the system headers so open source builds can
actually measure memory? It seems silly not to do this at this point.


More information about the webkit-reviews mailing list