[webkit-reviews] review granted: [Bug 200471] [WHLSL] Metal code generation unnecessarily does string copies by passing partial results as Strings : [Attachment 375632] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 200471: [WHLSL] Metal code generation unnecessarily does string copies by
passing partial results as Strings
https://bugs.webkit.org/show_bug.cgi?id=200471

Attachment 375632: Patch

https://bugs.webkit.org/attachment.cgi?id=375632&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375632
  --> https://bugs.webkit.org/attachment.cgi?id=375632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375632&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:93
> +	   // FIXME: Add direct StringBuilder -> NSString conversion to void
extra copy into a WTF::String

void => avoid

Maybe also worth filing a bug?

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:405
> +	   // FIXME: Add direct StringBuilder -> NSString conversion to void
extra copy into a WTF::String

ditto