[webkit-reviews] review granted: [Bug 200457] Adopt -expectMinimumUpcomingSampleBufferPresentationTime: : [Attachment 375584] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 200457: Adopt -expectMinimumUpcomingSampleBufferPresentationTime:
https://bugs.webkit.org/show_bug.cgi?id=200457

Attachment 375584: Patch

https://bugs.webkit.org/attachment.cgi?id=375584&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 375584
  --> https://bugs.webkit.org/attachment.cgi?id=375584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375584&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1279
> +    if (trackID != m_enabledVideoTrackID)
> +	   return;

Nit: canSetMinimumUpcomingPresentationTime has already done this check.

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1292
> +    int trackID = trackIDString.toInt();
> +    if (trackID != m_enabledVideoTrackID)
> +	   return;

Ditto