[webkit-reviews] review granted: [Bug 200453] [iPadOS] Unable to increase zoom level on Google using the Aa menu : [Attachment 375596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 5 22:01:41 PDT 2019


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 200453: [iPadOS] Unable to increase zoom level on Google using the Aa menu
https://bugs.webkit.org/show_bug.cgi?id=200453

Attachment 375596: Patch

https://bugs.webkit.org/attachment.cgi?id=375596&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 375596
  --> https://bugs.webkit.org/attachment.cgi?id=375596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375596&action=review

> Source/WebCore/page/ViewportConfiguration.cpp:250
> +	   return clampTo<double>(initialScale, shouldIgnoreScalingConstraints
? m_defaultConfiguration.minimumScale : m_configuration.minimumScale,
m_configuration.maximumScale);

Woah, there are some other places we should use this


More information about the webkit-reviews mailing list