[webkit-reviews] review granted: [Bug 200449] Web Inspector: RTL: go-to arrows and expand triangles in Computed panel should match their context : [Attachment 375567] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 200449: Web Inspector: RTL: go-to arrows and expand triangles in Computed
panel should match their context
https://bugs.webkit.org/show_bug.cgi?id=200449

Attachment 375567: Patch

https://bugs.webkit.org/attachment.cgi?id=375567&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375567
  --> https://bugs.webkit.org/attachment.cgi?id=375567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375567&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Main.css:289
> -body[dir=rtl] .go-to-arrow {
> +[dir=rtl] .go-to-arrow {

Will we need to worry about these?

    Views/DataGrid.css
    343:body[dir=ltr] .data-grid td .go-to-arrow {
    347:body[dir=rtl] .data-grid td .go-to-arrow {

I suspect this would affect positioning in Timeline Views, but I guess we won't
be overriding it again in any of those data grids.