[webkit-reviews] review granted: [Bug 200350] [WHLSL] Inline all native function calls : [Attachment 375560] patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 200350: [WHLSL] Inline all native function calls
https://bugs.webkit.org/show_bug.cgi?id=200350

Attachment 375560: patch

https://bugs.webkit.org/attachment.cgi?id=375560&action=review




--- Comment #9 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 375560
  --> https://bugs.webkit.org/attachment.cgi?id=375560
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375560&action=review

r=me

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:247
> +	       "if (", args[1], " < ", args[0], ".length) ", returnName, " =
&(", args[0], ".pointer[", args[1], "]);\n"

nit: might be simpler/shorter with a ternary conditional.