[webkit-reviews] review granted: [Bug 200413] [WHLSL] Store the short names of variables used by Metal generation directly in VariableDeclaration : [Attachment 375470] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 200413: [WHLSL] Store the short names of variables used by Metal generation
directly in VariableDeclaration
https://bugs.webkit.org/show_bug.cgi?id=200413

Attachment 375470: Patch

https://bugs.webkit.org/attachment.cgi?id=375470&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375470
  --> https://bugs.webkit.org/attachment.cgi?id=375470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375470&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   This appears to be a small perf improvement but my system is too
noisy to say exactly how much, and the patch is sufficiently simple I don't
think it deserves hours of super careful benchmarking.

nit: you should say the improvement is expected in WHLSL compile times