[webkit-reviews] review granted: [Bug 200395] Resource Load Statistics: Re-introduce latch mode for subresource cookie blocking : [Attachment 375427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 4 18:28:34 PDT 2019


Darin Adler <darin at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 200395: Resource Load Statistics: Re-introduce latch mode for subresource
cookie blocking
https://bugs.webkit.org/show_bug.cgi?id=200395

Attachment 375427: Patch

https://bugs.webkit.org/attachment.cgi?id=375427&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 375427
  --> https://bugs.webkit.org/attachment.cgi?id=375427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375427&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:142
> +    NSHTTPCookieStorage *storage = statelessCookieStorage();
> +    [m_task _setExplicitCookieStorage:storage._cookieStorage];

Since we’re collapsing this, I don’t think the local variable adds anything any
more. Could be a one liner instead.

    [m_task _setExplicitCookieStorage:statelessCookieStorage()._cookieStorage];


More information about the webkit-reviews mailing list