[webkit-reviews] review granted: [Bug 200429] Mangled WHLSL names don't need to allocate Strings : [Attachment 375508] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 4 18:15:36 PDT 2019

Saam Barati <sbarati at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 200429: Mangled WHLSL names don't need to allocate Strings

Attachment 375508: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 375508
  --> https://bugs.webkit.org/attachment.cgi?id=375508

View in context: https://bugs.webkit.org/attachment.cgi?id=375508&action=review


Just curious: Did you measure any compile time speedup? I like to flip the
“dumpPhaseTimes” Boolean to true in WHLSLPrepare and run some shaders to
measure compile time changes. I’ll email you the web page I use.

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:159
> +		   return string.is8Bit();

Why not an assert?

More information about the webkit-reviews mailing list