[webkit-reviews] review denied: [Bug 196956] Web Inspector: use weak collections for holding event listeners : [Attachment 372530] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 2 20:16:54 PDT 2019
Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 196956: Web Inspector: use weak collections for holding event listeners
https://bugs.webkit.org/show_bug.cgi?id=196956
Attachment 372530: Patch
https://bugs.webkit.org/attachment.cgi?id=372530&action=review
--- Comment #21 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 372530
--> https://bugs.webkit.org/attachment.cgi?id=372530
Patch
I don't like the idea of only Web Inspector having custom JS to iterate
WeakMap/Set. I'd rather we wait for something like WeakRef. I'm going to r- but
let me know if you disagree and I can take another look.
More information about the webkit-reviews
mailing list