[webkit-reviews] review granted: [Bug 200292] [ARM64E] Harden the diversity of the DOMJIT::Signature::unsafeFunction pointer. : [Attachment 375384] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 2 16:46:27 PDT 2019

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 200292: [ARM64E] Harden the diversity of the
DOMJIT::Signature::unsafeFunction pointer.

Attachment 375384: proposed patch.


--- Comment #12 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 375384
  --> https://bugs.webkit.org/attachment.cgi?id=375384
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=375384&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:71
> +	   : m_ptr((Ptr)&ptr)

Should be static cast

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:76
> +	   : m_ptr((Ptr)ptr)

Should be static cast

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:112
> +    constexpr Ptr ptr() const { return m_ptr; }

Smart pointers in WebKit usually call this function get()

More information about the webkit-reviews mailing list