[webkit-reviews] review granted: [Bug 200403] uniqueLogIdentifier() should generate a 64-bit identifier : [Attachment 375452] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 200403: uniqueLogIdentifier() should generate a 64-bit identifier
https://bugs.webkit.org/show_bug.cgi?id=200403

Attachment 375452: Patch

https://bugs.webkit.org/attachment.cgi?id=375452&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 375452
  --> https://bugs.webkit.org/attachment.cgi?id=375452
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375452&action=review

> Source/WTF/ChangeLog:12
> +	   uint32_t so use two to generate a 64-bit identifier.

Maybe we should have a way to print parent id as ABCD and child log identifier
as ABCD-EFGH so that it is easier to spot the relationship between parent and
child.
32 bits is probably enough for parent ids so that any id above 2^32 would be
printed as a child identifier.