[webkit-reviews] review granted: [Bug 200117] Web Inspector: Storage: disable related agents when the tab is closed : [Attachment 375368] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200117: Web Inspector: Storage: disable related agents when the tab is
closed
https://bugs.webkit.org/show_bug.cgi?id=200117

Attachment 375368: Patch

https://bugs.webkit.org/attachment.cgi?id=375368&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375368
  --> https://bugs.webkit.org/attachment.cgi?id=375368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375368&action=review

> Source/WebInspectorUI/UserInterface/Controllers/AppController.js:81
> +	       if (manager)
> +		   manager.activateExtraDomain(domain);

Can't wait to remove this code!

>
Source/WebInspectorUI/UserInterface/Controllers/ApplicationCacheManager.js:124
> +    networkStateUpdated(isNowOnline)

Maybe we should have a new section:

    // Protocol Callbacks

Or just:

    // ApplicationCacheObserver

And we can remove all these inner methods.

> Source/WebInspectorUI/UserInterface/Controllers/DOMStorageManager.js:105
>      itemsCleared(storageId)

Yeah, if we had:

    // DOMStorageObserver

Here that would save so much space!

> Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js:51
> -	   return !!window.DOMStorageAgent || !!window.DatabaseAgent ||
!!window.IndexedDBAgent;
> +	   return !!(InspectorBackend.domains.ApplicationCache ||
InspectorBackend.domains.DOMStorage || InspectorBackend.domains.Database ||
InspectorBackend.domains.IndexedDB);

We probably can't do this change until other work, since this should always be
true...

Once we do the BackendCommands rework we can do this!