[webkit-reviews] review granted: [Bug 200125] Web Inspector: Timelines: Develop > Start Timeline Recording doesn't work when focused on a detached inspector window : [Attachment 374920] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 200125: Web Inspector: Timelines: Develop > Start Timeline Recording
doesn't work when focused on a detached inspector window
https://bugs.webkit.org/show_bug.cgi?id=200125

Attachment 374920: Patch

https://bugs.webkit.org/attachment.cgi?id=374920&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 374920
  --> https://bugs.webkit.org/attachment.cgi?id=374920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374920&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:-115
> -- (void)showTimelines

This does appear to be dead code once we remove the Safari call and rely on
togglePageProfiling instead.

> Source/WebKit/UIProcess/WebInspectorProxy.cpp:350
>      m_isProfilingPage = !m_isProfilingPage;

Is this flag flipping now unnecessary, since we'll get notification from
WebProcess once it actually works? If recording fails to start for some reason,
this would erroneously think the timeline recording is active when it is not.