[webkit-reviews] review granted: [Bug 200165] WebSockets: response Set-Cookie header not handled when using platform APIs : [Attachment 375407] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 2 08:20:38 PDT 2019
youenn fablet <youennf at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 200165: WebSockets: response Set-Cookie header not handled when using
platform APIs
https://bugs.webkit.org/show_bug.cgi?id=200165
Attachment 375407: Patch
https://bugs.webkit.org/attachment.cgi?id=375407&action=review
--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 375407
--> https://bugs.webkit.org/attachment.cgi?id=375407
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375407&action=review
> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:54
> + , m_request(request)
Could be an r-value and moved here.
> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:111
> +
m_session->networkStorageSession()->setCookiesFromDOM(m_request.firstPartyForCo
okies(), SameSiteInfo::create(m_request),
The call to setCookiesFromDOM seems strange to me since this is a regular HTTP
response processing code path.
Looking at MacOS setCookiesFromDOM implementation, this is mostly ok except
that we are doing client-side cookie checks to validate the duration.
If we compare to the WebProcess handshake implementation, this is status quo
but I wonder if there is something better we could do here.
More information about the webkit-reviews
mailing list