[webkit-reviews] review granted: [Bug 200359] DOMWindow properties may get GC'd before their Window object : [Attachment 375345] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 22:36:23 PDT 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200359: DOMWindow properties may get GC'd before their Window object

Attachment 375345: Patch


--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 375345
  --> https://bugs.webkit.org/attachment.cgi?id=375345

View in context: https://bugs.webkit.org/attachment.cgi?id=375345&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4683
> +	       } elsif (GetGenerateIsReachable($interface) eq "ImplWindow") {

Can we use more sensible names like ReachableFromDOMWindow?
I really hate these Impl*. It doesn't explain what it does at all.

> LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html:13
> +    w = document.getElementById("testFrame").contentWindow;

Nit: Please don't use one letter variable like w.

> LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html:14
> +    for (let p of window_properties)

Dito for p. Also use camelCase?

> LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html:17
> +    for (let p of window_properties)


> LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html:26
> +	   for (let p of window_properties)


More information about the webkit-reviews mailing list