[webkit-reviews] review granted: [Bug 200242] macCatalyst build fails the first attempt, requires a second build : [Attachment 375103] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 200242: macCatalyst build fails the first attempt, requires a second build
https://bugs.webkit.org/show_bug.cgi?id=200242

Attachment 375103: Patch

https://bugs.webkit.org/attachment.cgi?id=375103&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 375103
  --> https://bugs.webkit.org/attachment.cgi?id=375103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375103&action=review

I think this looks right, but please confirm we aren't missing
'seatbelt-profile' stuff in the generated build.

> Source/WebKit/Scripts/process-entitlements.sh:77
> +    plistbuddy Add :com.apple.security.cs.allow-jit bool YES

Does this need a seatbelt-profiles array? It was present in the original
'entitlements' file.

    plistbuddy Add :seatbelt-profiles array
    plistbuddy Add :seatbelt-profiles:0 string com.apple.WebKit.WebContent

> Source/WebKit/Scripts/process-entitlements.sh:83
> +    plistbuddy Add :com.apple.security.network.client bool YES

Does this need a seatbelt-profiles array? It was present in the original
'entitlements' file.

    plistbuddy Add :seatbelt-profiles array
    plistbuddy Add :seatbelt-profiles:0 string com.apple.WebKit.Networking

> Source/WebKit/Scripts/process-entitlements.sh:142
> +    plistbuddy Add :com.apple.security.print 			     
bool YES

I don't believe we allow plugin process on iOS. Was there an entitlements file
for it?