[webkit-reviews] review denied: [Bug 200165] WebSockets: response Set-Cookie header not handled when using platform APIs : [Attachment 375338] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 200165: WebSockets: response Set-Cookie header not handled when using
platform APIs
https://bugs.webkit.org/show_bug.cgi?id=200165

Attachment 375338: Patch

https://bugs.webkit.org/attachment.cgi?id=375338&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375338
  --> https://bugs.webkit.org/attachment.cgi?id=375338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375338&action=review

Much better.

> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:109
> +	  
m_session->networkStorageSession()->setCookiesFromDOM(m_request.firstPartyForCo
okies(), SameSiteInfo::create(m_request),

You should probably check m_session before using it, since it's weak.

> Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:87
> +    // FIXME: support extensions and server cookie.

Actually, you should probably make an accessor for m_session on
NetworkSocketChannel then move your cookie setting code from
NetworkSocketChannel::didConnect to WebSocketTaskSoup.cpp because the cocoa
implementation won't be setting cookies like this.