[webkit-reviews] review granted: [Bug 200321] [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option : [Attachment 375322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 11:39:33 PDT 2019


Jonathan Bedard <jbedard at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 200321: [results.webkit.org] Timeline.CanvasXAxisComponent height should be
defined by option
https://bugs.webkit.org/show_bug.cgi?id=200321

Attachment 375322: Patch

https://bugs.webkit.org/attachment.cgi?id=375322&action=review




--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 375322
  --> https://bugs.webkit.org/attachment.cgi?id=375322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375322&action=review

> Tools/ChangeLog:9
> +	   Let the axis' height be defined in the option. Timeine compoenent
will use this value to 

Nit: 'component'
Nit: 'use this value as padding-top'


More information about the webkit-reviews mailing list