[webkit-reviews] review granted: [Bug 200327] B3 should support tuple types : [Attachment 375323] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 10:56:32 PDT 2019

Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 200327: B3 should support tuple types

Attachment 375323: Patch


--- Comment #6 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 375323
  --> https://bugs.webkit.org/attachment.cgi?id=375323

View in context: https://bugs.webkit.org/attachment.cgi?id=375323&action=review

Looks totally sensible. Now if only it would apply to trunk, build, pass tests,

> Source/JavaScriptCore/b3/B3ExtractValue.h:40
> +    int32_t offset() const { return m_value; }

Can you pick either calling it offset or something else and be consistent?

Seems like index is better. Offset suggests bytes to me.

More information about the webkit-reviews mailing list