[webkit-reviews] review granted: [Bug 199943] [SOUP] WebSockets: add support for extensions when using web sockets libsoup API : [Attachment 375306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 07:07:52 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 199943: [SOUP] WebSockets: add support for extensions when using web
sockets libsoup API
https://bugs.webkit.org/show_bug.cgi?id=199943

Attachment 375306: Patch

https://bugs.webkit.org/attachment.cgi?id=375306&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375306
  --> https://bugs.webkit.org/attachment.cgi?id=375306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375306&action=review

great

> Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:79
> +    return m_extensions.isNull() ? emptyString(): m_extensions;

space before colon


More information about the webkit-reviews mailing list