[webkit-reviews] review granted: [Bug 191498] [Curl] implement CertificateInfo::summaryInfo : [Attachment 375286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 07:04:49 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 191498: [Curl] implement CertificateInfo::summaryInfo

Attachment 375286: Patch


--- Comment #38 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375286
  --> https://bugs.webkit.org/attachment.cgi?id=375286

View in context: https://bugs.webkit.org/attachment.cgi?id=375286&action=review

r=me with a few nits.
ews failure is unrelated

> Source/WebCore/platform/network/curl/CertificateInfo.h:-79
> -    static bool decode(Decoder&, WebCore::CertificateInfo&)

Please use modern decoding that returns an Optional<WebCore::CertificateInfo>.
Decoders that return a bool prevent us from removing default constructors in
decodable classes.

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:171
> +static Optional<String> toString(const ASN1_STRING* name)

These can just return a String, which has a null state.

More information about the webkit-reviews mailing list